Summary: | ASSERTION FAILED: m_state == State::Committed in WebKit::FrameLoadState::didFailLoad() | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||||||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, beidson, cdumez, ews-watchlist, japhet, jenner, julian_a_gonzalez, mifenton, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | Other | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=222819 | ||||||||||||
Attachments: |
|
Description
Ryan Haddad
2021-02-11 16:56:53 PST
It looks like this may have started after https://trac.webkit.org/changeset/272396/webkit landed https://trac.webkit.org/changeset/272396/webkit introduced this test - looks like in Debug mode, a followup change is required. It's actually the test introduced in https://trac.webkit.org/changeset/254662/webkit. Skipped the test on debug bots in https://commits.webkit.org/r273110 for now. Committed r273110 (234307@main): <https://commits.webkit.org/234307@main> Created attachment 421014 [details]
Patch
Added a patch to get a specific callstack (this isn't reproducible for me locally, but EWS can hit it). *** Bug 222819 has been marked as a duplicate of this bug. *** Created attachment 423277 [details]
Patch
Comment on attachment 423277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423277&action=review > Source/WebCore/editing/FrameSelection.cpp:184 > - setCaretVisibility(activeAndFocused ? Visible : Hidden); > + setCaretVisibility(activeAndFocused ? Visible : Hidden, false); Please add new enum class maybe something like: ShouldUpdateAppearance { Yes, No } Comment on attachment 423277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423277&action=review >> Source/WebCore/editing/FrameSelection.cpp:184 >> + setCaretVisibility(activeAndFocused ? Visible : Hidden, false); > > Please add new enum class maybe something like: ShouldUpdateAppearance { Yes, No } Or preferably: enum class ShouldUpdateAppearance : bool { No, Yes } (using bool underlying type and 0 meaning No, not Yes). Created attachment 423289 [details]
Patch
Comment on attachment 423289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423289&action=review > Source/WebCore/editing/FrameSelection.h:302 > + enum ShouldUpdateAppearance : bool { No, Yes }; Please use enum class, not enum. Otherwise, there will be implicit type coercion between this type and bool, and No/Yes will pollute the namespace within FrameSelection. Created attachment 423364 [details]
Patch
Committed r274526: <https://commits.webkit.org/r274526> All reviewed patches have been landed. Closing bug and clearing flags on attachment 423364 [details]. |