Bug 221773

Summary: [Cocoa] IPC decoder is using decoded size to allocate memory for an array
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit2Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224984
Attachments:
Description Flags
Patch ggaren: review+

Darin Adler
Reported 2021-02-11 12:51:38 PST
[Cocoa] IPC decoder is using decoded size to allocate memory for an array
Attachments
Patch (1.77 KB, patch)
2021-02-11 12:53 PST, Darin Adler 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-02-11 12:53:17 PST
Created attachment 420032 [details] Patch
Darin Adler
Comment 2 2021-02-11 12:53:50 PST
rdar://72808726
Geoffrey Garen
Comment 3 2021-02-11 13:04:06 PST
Comment on attachment 420032 [details] Patch r=me I wonder if we should honor some safe nominal capacity, like std::min(1024, size), for performance.
Darin Adler
Comment 4 2021-02-11 13:29:08 PST
(In reply to Geoffrey Garen from comment #3) > I wonder if we should honor some safe nominal capacity, like std::min(1024, > size), for performance. We don’t do that for CFArray or for vectors, but I agree that it *might* be a valuable optimization for cases like these.
Darin Adler
Comment 5 2021-02-11 13:30:38 PST
Committed r272744: <https://trac.webkit.org/changeset/272744>
Note You need to log in before you can comment on or make changes to this bug.