Bug 221769

Summary: Reduce unnecessary string copies in ParsedRequestRange and ParsedContentRange
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch ggaren: review+, ews-feeder: commit-queue-

Alex Christensen
Reported 2021-02-11 12:11:39 PST
Reduce unnecessary string copies in ParsedRequestRange and ParsedContentRange
Attachments
Patch (10.13 KB, patch)
2021-02-11 12:12 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (10.11 KB, patch)
2021-02-11 13:24 PST, Alex Christensen 		ggaren: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-02-11 12:12:34 PST
Created attachment 420023 [details] Patch
Alex Christensen
Comment 2 2021-02-11 13:24:11 PST
Created attachment 420035 [details] Patch
Sam Weinig
Comment 3 2021-02-11 13:54:56 PST
If you want to be even more efficient, you can also consider adopting StringParsingBuffer + ParserUtilities.h, which avoids a bunch of the branches StringView has to do on each call by doing the branch up front. Just grep in WebCore for StringParsingBuffer to see some examples of it being used.
Alex Christensen
Comment 4 2021-02-11 14:20:04 PST
That's true, but I don't think there is much difference in this case because toInt64Strict and toUInt64Strict only have one check for 8-bit or 16-bit, then they call specialized parsers themselves.
Radar WebKit Bug Importer
Comment 5 2021-02-18 12:12:13 PST
<rdar://problem/74489102>
Geoffrey Garen
Comment 6 2021-03-09 16:22:23 PST
Comment on attachment 420035 [details] Patch r=me
EWS
Comment 7 2021-03-09 16:37:21 PST
Tools/Scripts/svn-apply failed to apply attachment 420035 [details] to trunk. Please resolve the conflicts and upload a new patch.
Alex Christensen
Comment 8 2021-03-09 16:43:36 PST
r274187
Note You need to log in before you can comment on or make changes to this bug.