| Summary: | Reduce unnecessary string copies in ParsedRequestRange and ParsedContentRange | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, ggaren, sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-02-11 12:11:39 PST
Created attachment 420023 [details]
Patch
Created attachment 420035 [details]
Patch
If you want to be even more efficient, you can also consider adopting StringParsingBuffer + ParserUtilities.h, which avoids a bunch of the branches StringView has to do on each call by doing the branch up front. Just grep in WebCore for StringParsingBuffer to see some examples of it being used. That's true, but I don't think there is much difference in this case because toInt64Strict and toUInt64Strict only have one check for 8-bit or 16-bit, then they call specialized parsers themselves. Comment on attachment 420035 [details]
Patch
r=me
Tools/Scripts/svn-apply failed to apply attachment 420035 [details] to trunk.
Please resolve the conflicts and upload a new patch.
|