Bug 221728

Summary:

Web Inspector: Grid section in Layout panel gets out of sync with grid overlay after reopening Web Inspector

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Razvan Caliman <rcaliman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, rcaliman, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Nikita Vasilyev 2021-02-10 16:37:48 PST

Steps:
1. Open https://labs.jensimmons.com
2. Open Elements tab, Layout panel
3. Check `div.header-wrapper`
4. Close Web Inspector; the grid overlay stays on
5. Open Web Inspector again

Expected:
`div.header-wrapper` remains checked

Actual:
`div.header-wrapper` is unchecked

Notes:
We should hide the overlays when closing Web Inspector.

Comment 1 Radar WebKit Bug Importer 2021-02-10 16:37:56 PST

<rdar://problem/74212444>

Comment 2 Razvan Caliman 2021-02-11 10:44:17 PST

Created attachment 420002 [details]
Patch

Comment 3 BJ Burg 2021-02-11 10:46:11 PST

Comment on attachment 420002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420002&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Hide all shown grid overlays when the WebInspector is closed.

Nit: Web Inspector

Comment 4 EWS 2021-02-11 11:12:22 PST

Committed r272739: <https://commits.webkit.org/r272739>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 420002 [details].