| Summary: | [CMake] Bump cmake_minimum_required version to 3.12 or later | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||
| Component: | CMake | Assignee: | Don Olmstead <don.olmstead> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, aperez, cgarcia, clopez, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, webkit-bug-importer, yurys | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=248246 | ||||||||
| Attachments: |
|
||||||||
|
Description
Don Olmstead
2021-02-10 16:24:18 PST
Created attachment 422370 [details]
Patch
Believe GTK has branched so this can potentially land. This opens up GTK to build with hidden visibility turned on. (In reply to Don Olmstead from comment #3) > Believe GTK has branched so this can potentially land. Yes, Carlos has created our 2.32.x release branch some days ago. > This opens up GTK to build with hidden visibility turned on. \o/ Comment on attachment 422370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422370&action=review > CMakeLists.txt:9 > +cmake_minimum_required(VERSION 3.12) cmake_minimum_required(VERSION 3.10) is also present in subprojects, such as Source/WTF/CMakeLists.txt (In reply to Konstantin Tokarev from comment #5) > Comment on attachment 422370 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422370&action=review > > > CMakeLists.txt:9 > > +cmake_minimum_required(VERSION 3.12) > > cmake_minimum_required(VERSION 3.10) is also present in subprojects, such as > Source/WTF/CMakeLists.txt Good catch forgot about the AppleWin build doing that. Created attachment 422376 [details]
Patch
Comment on attachment 422376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422376&action=review > CMakeLists.txt:13 > -cmake_minimum_required(VERSION 3.10) > +# cmake_minimum_required is also set inside Source/${FRAMEWORK}/CMakeLists.txt > +# in support of the AppleWin internal build so this version should be kept in > +# sync across those files. > +# > +cmake_minimum_required(VERSION 3.12) Added a note here about that annulen Comment on attachment 422376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422376&action=review >> CMakeLists.txt:13 >> +cmake_minimum_required(VERSION 3.12) > > Added a note here about that annulen Great idea, similar mistakes were made in the past too Committed r273984: <https://commits.webkit.org/r273984> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422376 [details]. This broke compilation on Ubuntu 18.04 as it comes with cmake 3.10. I'd point to the Ububntu 1804 build bot but has been in a bad state for a different reason (https://build.webkit.org/#/builders/71). Is it possible to keep the min cmake version at 3.10 while Ubuntu 1804 is an officially supported LTS? Hi Yury, support for Ubuntu 18.04's toolchain ends in April according to https://trac.webkit.org/wiki/WebKitGTK/DependenciesPolicy. WebKitGTK 2.32 has already been branched so Ubuntu has until September, when WebKitGTK 2.34 will be released, to figure out what to do. You should still be able to build for Ubuntu 18.04 if you build your own CMake. Hi Michael, thanks for quick response and for the pointer to the policy! I ended up building cmake from source for now, should fix the problem. Note that the patch in bug #181916 depends on cmake 3.12. |