Bug 221726

Summary: [CMake] Enable hidden visibility on JSCOnly
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch + a jsc.cpp modification to prevent EWS ignoring none

Don Olmstead
Reported 2021-02-10 16:15:15 PST
...
Attachments
Patch (1.96 KB, patch)
2021-02-10 16:29 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch + a jsc.cpp modification to prevent EWS ignoring (1.67 KB, patch)
2021-02-10 16:40 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-02-10 16:29:51 PST
Created attachment 419920 [details] Patch
Don Olmstead
Comment 2 2021-02-10 16:40:00 PST
Created attachment 419921 [details] Patch + a jsc.cpp modification to prevent EWS ignoring The EWS for JSCOnly builds ignored the actual patch so modifying a file to make them not skip a build.
Yusuke Suzuki
Comment 3 2021-02-10 17:29:33 PST
Comment on attachment 419920 [details] Patch r=me
EWS
Comment 4 2021-02-10 18:22:28 PST
Committed r272699: <https://commits.webkit.org/r272699> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419920 [details].
Note You need to log in before you can comment on or make changes to this bug.