Bug 221699

Summary: Check for empty on JSValue cell type checks
Product: WebKit Reporter: Tadeu Zagallo <tzagallo>
Component: JavaScriptCoreAssignee: Tadeu Zagallo <tzagallo>
Status: RESOLVED INVALID    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Tadeu Zagallo
Reported 2021-02-10 11:01:51 PST
...
Attachments
Patch (1.65 KB, patch)
2021-02-10 11:15 PST, Tadeu Zagallo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tadeu Zagallo
Comment 1 2021-02-10 11:15:46 PST
Created attachment 419871 [details] Patch
Saam Barati
Comment 2 2021-02-10 11:16:41 PST
Comment on attachment 419871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419871&action=review > Source/JavaScriptCore/ChangeLog:3 > + Check for empty on JSValue cell type checks Can we add tests?
Tadeu Zagallo
Comment 3 2021-02-11 13:16:53 PST
It's impossible to have a valid `JSValue *` where `m_value` is `NULL`.
Note You need to log in before you can comment on or make changes to this bug.