Bug 221684

Summary: Do not differentiate between Release and Production via ENABLE_DEVELOPER_MODE
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, jer.noble, philipj, sam, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221621
Attachments:
Description Flags
proposed patch none

Description Alexey Proskuryakov 2021-02-10 10:02:55 PST 
There is some code that sets ENABLE_DEVELOPER_MODE in xcconfigs depending on whether the build is Production or Debug/Release.

It is invalid to create behaviors that are different between these. There is almost no difference in usage scenarios between build modes - either can be produced by CI for validation, either can be used for local testing, etc.

Seeing how it's used for making media elements debuggable, I'm certain that there is a better way to achieve the goal. I don't think that implementing this better way needs to be done as part of this patch.

Not really sure what's up with developer modein WebInspectorUI, seems unused?
Comment 1 Alexey Proskuryakov 2021-02-10 10:06:21 PST 
Created attachment 419863 [details]
proposed patch
Comment 2 EWS 2021-02-10 12:55:07 PST 
Committed r272679: <https://commits.webkit.org/r272679>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419863 [details].
Comment 3 Radar WebKit Bug Importer 2021-02-10 14:26:31 PST 
<rdar://problem/74206304>