Bug 221639

Summary: Use CompletionHandler instead of DataCallback
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, ews-watchlist, gustavo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221672
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-02-09 16:01:26 PST
Use CompletionHandler instead of DataCallback
Attachments
Patch (34.00 KB, patch)
2021-02-09 16:01 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (34.23 KB, patch)
2021-02-09 16:57 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (36.11 KB, patch)
2021-02-09 17:23 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (37.82 KB, patch)
2021-02-09 20:50 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (38.13 KB, patch)
2021-02-09 21:16 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-02-09 16:01:53 PST
Created attachment 419779 [details] Patch
Alex Christensen
Comment 2 2021-02-09 16:57:20 PST
Created attachment 419786 [details] Patch
Alex Christensen
Comment 3 2021-02-09 17:23:12 PST
Created attachment 419790 [details] Patch
EWS Watchlist
Comment 4 2021-02-09 17:24:04 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 5 2021-02-09 20:50:35 PST
Created attachment 419809 [details] Patch
Alex Christensen
Comment 6 2021-02-09 21:16:44 PST
Created attachment 419812 [details] Patch
Alex Christensen
Comment 7 2021-02-09 21:21:26 PST
http://trac.webkit.org/r272636
Radar WebKit Bug Importer
Comment 8 2021-02-09 21:22:15 PST
<rdar://problem/74174432>
Carlos Garcia Campos
Comment 9 2021-02-10 07:02:51 PST
Comment on attachment 419812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419812&action=review > Source/WebKit/UIProcess/API/glib/WebKitWebResource.cpp:-351 > - if (error != CallbackBase::Error::None) { > - // This fails when the page is closed or frame is destroyed, so we can just cancel the operation. > - g_task_return_new_error(task, G_IO_ERROR, G_IO_ERROR_CANCELLED, _("Operation was cancelled")); > - return; > - } We need to bring this back to fix bug #221672. I think the equivalent now would be to just null check wkData
Alex Christensen
Comment 10 2021-02-18 15:59:22 PST
Comment on attachment 419812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419812&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2523 > + completionHandler(wrapper(*data), nil); This was a little optimistic. See https://bugs.webkit.org/show_bug.cgi?id=222139
Note You need to log in before you can comment on or make changes to this bug.