| Summary: | Use CompletionHandler instead of ApplicationManifestCallback | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Alex Christensen
2021-02-09 13:59:58 PST
Created attachment 419760 [details]
Patch
Comment on attachment 419760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419760&action=review > Source/WebKit/WebProcess/WebPage/WebPage.h:2184 > + HashMap<uint64_t, CompletionHandler<void(const Optional<WebCore::ApplicationManifest>&)>> m_applicationManifestFetchCallbackMap; Now that you are storing CompletionHandlers in a data member, you may need to do something in the WebPage destructor to make sure all remaining completion handlers are called before destruction. Otherwise, you may end up with debug assertion hits in some cases. Created attachment 419768 [details]
Patch
Created attachment 419794 [details]
Patch
Created attachment 419811 [details]
Patch
|