Bug 221596

Summary: Reduce the overhead of HTMLDocumentParser in innerHTML setter
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kangil.han, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Patch for landing none

Ryosuke Niwa
Reported 2021-02-09 00:23:11 PST
There is a bunch of overhead in running the full HTMLDocumentParser. We should add some fast paths to speed things up for innerHTML.
Attachments
WIP (3.98 KB, patch)
2021-02-09 00:23 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (6.09 KB, patch)
2021-02-09 15:36 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch (6.15 KB, patch)
2021-02-09 15:37 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.15 KB, patch)
2021-02-09 15:49 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-02-09 00:23:53 PST
Created attachment 419683 [details] WIP
Ryosuke Niwa
Comment 2 2021-02-09 15:36:20 PST
Created attachment 419775 [details] Patch
Ryosuke Niwa
Comment 3 2021-02-09 15:37:33 PST
Created attachment 419776 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-02-09 15:40:14 PST
Comment on attachment 419776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419776&action=review > Source/WebCore/html/parser/HTMLDocumentParser.cpp:519 > + // HTMLTreeBuilder may have a parser blokcing script element but we ignore them during fragment parsing. blokcing
Ryosuke Niwa
Comment 5 2021-02-09 15:47:45 PST
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 419776 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419776&action=review > > > Source/WebCore/html/parser/HTMLDocumentParser.cpp:519 > > + // HTMLTreeBuilder may have a parser blokcing script element but we ignore them during fragment parsing. > > blokcing Fixed.
Ryosuke Niwa
Comment 6 2021-02-09 15:49:14 PST
Created attachment 419778 [details] Patch for landing
EWS
Comment 7 2021-02-09 16:38:21 PST
Committed r272622: <https://commits.webkit.org/r272622> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419778 [details].
Radar WebKit Bug Importer
Comment 8 2021-02-09 17:18:53 PST
<rdar://problem/74167433>
Note You need to log in before you can comment on or make changes to this bug.