Bug 221591

Summary: Add API to disable HTTPS upgrade
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, glenn, gyuyoung.kim, japhet, jer.noble, macpherson, menard, philipj, sergio, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2021-02-08 19:19:29 PST
Add API to disable HTTPS upgrade
Attachments
Patch (28.81 KB, patch)
2021-02-08 19:28 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (26.32 KB, patch)
2021-02-12 10:11 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-02-08 19:28:12 PST
Created attachment 419669 [details] Patch
Geoffrey Garen
Comment 2 2021-02-08 21:06:43 PST
Comment on attachment 419669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419669&action=review r=me > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h:134 > +/*! @abstract A Boolean value indicating whether HTTP requests to servers known to support HTTPS should be automatically upgraded to HTTPS requests. > + @discussion The default value is YES. > + */ > +@property (nonatomic) BOOL upgradeCommonKnownRequestsToHTTPS WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); This property should probably go through API review. I think "upgradeKnownHostsToHTTPS" might be a better name. I removed "Common" because common is not an clear threshold, and probably not the salient part of the feature. I changed "Requests" to "Hosts" because the feature is per-host. This will get a little awkward if we ever offer API to disable HSTS. Oh well.
Alex Christensen
Comment 3 2021-02-12 10:11:21 PST
Created attachment 420141 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-02-15 19:20:16 PST
<rdar://problem/74375950>
Alex Christensen
Comment 5 2021-02-16 11:40:25 PST
http://trac.webkit.org/r272920
Note You need to log in before you can comment on or make changes to this bug.