Bug 22155
| Summary: | REGRESSION (r38261): "Created an attachment" links for non-patches link to "Review Patch" page, but should not | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | WebKit Website | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | https://bugs.webkit.org/show_bug.cgi?id=3235#c2 | ||
Adam Roben (:aroben)
To reproduce:
1. Go to https://bugs.webkit.org/show_bug.cgi?id=3235#c2
Note that the link in that comment now reads:
> Created an attachment (id=5331) [review]
The text "[review]" links to the "Review Patch" page for this attachment. But the attachment is a test case, not a patch, so we should not be linking to "Review Patch" for it at all. We could probably just omit the "[review]" text entirely in this case.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
Well, Bugzilla's "smart" formatting screwed up the quoted part of my previous comment, but you get the point.
Darin Adler
This won't be easy to fix. The level of code dealing with the attachment has only the attachment number and has no way to figure out if the attachment is a patch or not. It's formatting a description and not doing database access.
Adam Roben (:aroben)
(In reply to comment #2)
> This won't be easy to fix. The level of code dealing with the attachment has
> only the attachment number and has no way to figure out if the attachment is a
> patch or not. It's formatting a description and not doing database access.
It looks to me like GetAttachmentLink does in fact do database access:
https://trac.webkit.org/browser/trunk/BugsSite/globals.pl?rev=38261#L866
Darin Adler
OK, then maybe it will be easy!