Bug 221521

Summary: WebCore::genericFamily() should use checked_cf_cast<>
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: TextAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mmaxfield, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=221428
Attachments:
Description Flags
Patch v1
sam: review+, ddkilzer: commit-queue-
Patch for landing none

David Kilzer (:ddkilzer)
Reported 2021-02-06 11:16:09 PST
WebCore::genericFamily() should use static_cf_cast<>. See notes in Bug 221428 Comment #0: <https://bugs.webkit.org/show_bug.cgi?id=221428#c0>
Attachments
Patch v1 (1.85 KB, patch)
2021-02-06 11:18 PST, David Kilzer (:ddkilzer) 		sam: review+
ddkilzer: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (1.82 KB, patch)
2021-02-10 17:35 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-02-06 11:18:26 PST
Created attachment 419512 [details] Patch v1
Sam Weinig
Comment 2 2021-02-07 10:05:41 PST
Comment on attachment 419512 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review > Source/WebCore/ChangeLog:10 > + - Switch from dynamic_cf_cast<> to static_cf_cast<> because we Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title.
David Kilzer (:ddkilzer)
Comment 3 2021-02-08 11:53:00 PST
Comment on attachment 419512 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review >> Source/WebCore/ChangeLog:10 >> + - Switch from dynamic_cf_cast<> to static_cf_cast<> because we > > Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title. Ha! This is what happens when I write patches on the weekend now. :) Thanks for catching.
David Kilzer (:ddkilzer)
Comment 4 2021-02-10 17:35:09 PST
Created attachment 419929 [details] Patch for landing
EWS
Comment 5 2021-02-10 18:25:09 PST
Committed r272700: <https://commits.webkit.org/r272700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419929 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-10 18:26:32 PST
<rdar://problem/74216540>
Note You need to log in before you can comment on or make changes to this bug.