Summary: | Check that CGPDFDocumentRef is consistently unlocked and printable | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | |||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2021-02-05 18:32:42 PST
Created attachment 419489 [details]
Patch v1
Comment on attachment 419489 [details]
Patch v1
Looks good. I think there is testing infra for password PDFs. I don't remember if it covered printing code path. Consider taking a look and writing a test. This is not required.
Committed r272506: <https://commits.webkit.org/r272506> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419489 [details]. |