Bug 221465

Summary:

Add support for modifier keys in test_driver.send_keys()

Product:

WebKit

Reporter:

Manuel Rego Casasnovas <rego>

Component:

Tools / Tests

Assignee:

Manuel Rego Casasnovas <rego>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, clopez, ews-watchlist, gsnedders, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://github.com/web-platform-tests/wpt/pull/27550

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Manuel Rego Casasnovas

Reported 2021-02-05 07:36:11 PST

There's a FIXME about that in LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (https://webkit-search.igalia.com/webkit/source/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js#158): // FIXME: Add the support for modifier keys. This causes that we cannot do things like test_driver.send_keys(element, "\uE009" + "Y") (Ctrl + Y). Chromium supports this with the following code: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/resources/testdriver-vendor.js;l=100?q=testdriver-vendor.js

Attachments
Patch (6.25 KB, patch) 2021-02-09 08:35 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (9.82 KB, patch) 2021-02-10 01:25 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (9.88 KB, patch) 2021-02-10 02:08 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (9.82 KB, patch) 2021-02-10 02:15 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Patch (9.82 KB, patch) 2021-02-10 02:46 PST, Manuel Rego Casasnovas	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Manuel Rego Casasnovas

Comment 1 2021-02-09 08:35:49 PST

Created attachment 419720 [details] Patch

EWS Watchlist

Comment 2 2021-02-09 08:37:05 PST

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

Manuel Rego Casasnovas

Comment 3 2021-02-10 01:25:36 PST

Created attachment 419827 [details] Patch

Manuel Rego Casasnovas

Comment 4 2021-02-10 02:08:28 PST

Created attachment 419828 [details] Patch

Manuel Rego Casasnovas

Comment 5 2021-02-10 02:15:25 PST

Created attachment 419829 [details] Patch

Manuel Rego Casasnovas

Comment 6 2021-02-10 02:46:18 PST

Created attachment 419831 [details] Patch