Bug 221455

Summary:

Move AudioHardwareListener into the GPU Process

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, mkwst, philipj, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221732

Attachments:

Description	Flags
Patch	eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none

Jer Noble

Reported 2021-02-05 01:36:25 PST

Move AudioHardwareListener into the GPU Process

Attachments
Patch (39.83 KB, patch) 2021-02-05 01:41 PST, Jer Noble	eric.carlson: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (39.92 KB, patch) 2021-02-10 17:59 PST, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (39.98 KB, patch) 2021-02-10 18:10 PST, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (40.02 KB, patch) 2021-02-10 18:18 PST, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (40.97 KB, patch) 2021-02-10 19:52 PST, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (40.64 KB, patch) 2021-02-10 19:54 PST, Jer Noble	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2021-02-05 01:41:13 PST

Created attachment 419373 [details] Patch

Eric Carlson

Comment 2 2021-02-05 10:45:46 PST

Comment on attachment 419373 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419373&action=review We will have to reestablish the connection when the GPU process crashes. > Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.h:43 > +class RemoteAudioHardwareListenerProxy : private WebCore::AudioHardwareListener::Client { Nit: final > Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.h:52 > + void audioHardwareDidBecomeActive() override; > + void audioHardwareDidBecomeInactive() override; Ditto.

Jer Noble

Comment 3 2021-02-10 17:59:05 PST

Created attachment 419933 [details] Patch for landing

Jer Noble

Comment 4 2021-02-10 18:10:58 PST

Created attachment 419934 [details] Patch for landing

Jer Noble

Comment 5 2021-02-10 18:18:39 PST

Created attachment 419936 [details] Patch for landing

Jer Noble

Comment 6 2021-02-10 19:52:00 PST

Created attachment 419939 [details] Patch for landing

Jer Noble

Comment 7 2021-02-10 19:54:59 PST

Created attachment 419940 [details] Patch for landing

EWS

Comment 8 2021-02-10 23:24:30 PST

Committed r272709: <https://commits.webkit.org/r272709> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419940 [details].

Radar WebKit Bug Importer

Comment 9 2021-02-10 23:25:14 PST

<rdar://problem/74223164>

Note You need to log in before you can comment on or make changes to this bug.