| Summary: | [GTK] clang warnings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | WebKitGTK | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 419286 [details]
Patch
Created attachment 419289 [details]
Patch
/Volumes/Data/worker/Commit-Queue/build/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Comment on attachment 419289 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419289&action=review > Source/WebKit/ChangeLog:5 > + Good Guy Style Cheker™ caught this one: the “Reviewed by” line is missing; please add it before landing =} Committed r272408: <https://trac.webkit.org/changeset/272408> |
[4882/5293] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-3.cpp.o In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-88d1702b-3.cpp:1: ../../Source/WebKit/UIProcess/SpeechRecognitionServer.cpp:162:129: warning: format specifies type 'unsigned long long' but the argument has type 'uint64_t' (aka 'unsigned long') [-Wformat] WTFLogAlways("[%p]SpeechRecognitionServer::sendUpdate update.type[%d], update.clientIdentifier[%llu]", this, update.type(), update.clientIdentifier().toUInt64()); ~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ %lu 1 warning generated. [4899/5293] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-72468c22-2.cpp.o In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-72468c22-2.cpp:8: ../../Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:378:17: warning: enumeration value 'Model' not handled in switch [-Wswitch] switch (destination) { ^ 1 warning generated. [5086/5293] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-27.cpp.o In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-27.cpp:8: ../../Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp:160:14: warning: private field 'm_numberOfFrames' is not used [-Wunused-private-field] uint64_t m_numberOfFrames { 0 }; ^ 1 warning generated.