| Summary: | Process LocalizableAdditions string file correctly. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, ews-watchlist, hi, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Megan Gardner
2021-02-03 15:08:19 PST
Created attachment 419189 [details]
Patch
Comment on attachment 419189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419189&action=review > Source/WebCore/DerivedSources-input.xcfilelist:1064 > +$(PROJECT_DIR)/make-localizable-strings.pl I would call this preprocess-; it's not making them > Source/WebCore/DerivedSources.make:1324 > +ADDITIONAL_PATHS = \ I feel like there's a noun missing here. > Source/WebCore/DerivedSources.make:1506 > +# .string files string/s/ > Source/WebCore/bindings/scripts/preprocessor.pm:59 > + if ($keepComments) { > + push(@args, qw(-E -P -C -x c++)); > + } > + else { > + push(@args, qw(-E -P -x c++)); > + } I would write this: push(@args, qw(-E -P -x c++)); if ($keepComments) { push(@args, qw(-C)); } Created attachment 419206 [details]
Patch
Created attachment 419209 [details]
Patch
Committed r272377: <https://trac.webkit.org/changeset/272377> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419209 [details]. |