Bug 221358 – Process LocalizableAdditions string file correctly.

• Component: New Bugs
• Status: RESOLVED FIXED

[Megan Gardner]

Process LocalizableAdditions string file correctly.

[Megan Gardner]

Created attachment 419189 [details]
Patch

[Tim Horton]

Comment on attachment 419189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419189&action=review

> Source/WebCore/DerivedSources-input.xcfilelist:1064
> +$(PROJECT_DIR)/make-localizable-strings.pl

I would call this preprocess-; it's not making them

> Source/WebCore/DerivedSources.make:1324
> +ADDITIONAL_PATHS = \

I feel like there's a noun missing here.

> Source/WebCore/DerivedSources.make:1506
> +# .string files

string/s/

> Source/WebCore/bindings/scripts/preprocessor.pm:59
> +            if ($keepComments) {
> +                push(@args, qw(-E -P -C -x c++));
> +            }
> +            else {
> +                push(@args, qw(-E -P -x c++));
> +            }

I would write this:
    push(@args, qw(-E -P -x c++));
    if ($keepComments) {
        push(@args, qw(-C));
    }

[Megan Gardner]

Created attachment 419206 [details]
Patch

[Megan Gardner]

Created attachment 419209 [details]
Patch

[EWS]

Committed r272377: <https://trac.webkit.org/changeset/272377>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419209 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73989711>