Bug 221324

Summary: Improve the serialization of scroll-snap-type and scroll-snap-align
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, clopez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jbedard, macpherson, menard, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218115    
Attachments:
Description Flags
Patch
none
Patch
none
Patch ews-feeder: commit-queue-

Martin Robinson
Reported 2021-02-03 05:08:55 PST
These two properties have some issues when it comes to serialization in computed style as well as when calling `getPropertyValue`.
Attachments
Patch (34.99 KB, patch)
2021-02-03 07:48 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (75.37 KB, patch)
2021-02-03 09:03 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (366.45 KB, patch)
2021-02-05 08:30 PST, alan 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-02-03 07:48:24 PST
Created attachment 419138 [details] Patch
Alex Christensen
Comment 2 2021-02-03 08:29:18 PST
Comment on attachment 419138 [details] Patch Looks like there's one more test to update, but r=me
Martin Robinson
Comment 3 2021-02-03 09:03:08 PST
Created attachment 419145 [details] Patch
Martin Robinson
Comment 4 2021-02-04 03:39:13 PST
Comment on attachment 419145 [details] Patch Thanks for the review!
EWS
Comment 5 2021-02-04 04:01:35 PST
Committed r272366: <https://trac.webkit.org/changeset/272366> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419145 [details].
Radar WebKit Bug Importer
Comment 6 2021-02-04 04:02:15 PST
<rdar://problem/73975303>
alan
Comment 7 2021-02-05 08:30:27 PST
Reopening to attach new patch.
alan
Comment 8 2021-02-05 08:30:30 PST
Created attachment 419411 [details] Patch
Martin Robinson
Comment 9 2021-02-05 08:33:58 PST
Hi Zalan, looking at the patch, I think this might be the wrong bug.
EWS Watchlist
Comment 10 2021-02-05 09:59:04 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
alan
Comment 11 2021-02-05 10:25:29 PST
(In reply to Martin Robinson from comment #9) > Hi Zalan, looking at the patch, I think this might be the wrong bug. Right, sorry. webkit-patch upload messed it up.
alan
Comment 12 2021-02-05 10:28:22 PST
(In reply to zalan from comment #11) > (In reply to Martin Robinson from comment #9) > > Hi Zalan, looking at the patch, I think this might be the wrong bug. > Right, sorry. webkit-patch upload messed it up. Oh the changelog diff must have confused the script (my change is not at the top of the file) even though I explicitly passed in the correct bug id :shrugs:
Note You need to log in before you can comment on or make changes to this bug.