Summary: | Avoid frequent calls to HTMLFormControlElement::updateValidity() when constructing form control elements | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Forms | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, mifenton, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2021-02-02 22:06:44 PST
Created attachment 419107 [details]
Patch
Comment on attachment 419107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419107&action=review > Source/WebCore/html/HTMLInputElement.cpp:826 > + DelayedUpdateValidityScope delayedUpdateValidityScope(*this); > + I don't think it's possible for this function to get called recursively. Why don't we just put a boolean like m_initializingParserSetAttributes instead? Comment on attachment 419107 [details]
Patch
r=me
I tried the boolean thing and it just feels uglier. Committed r272354: <https://trac.webkit.org/changeset/272354> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419107 [details]. |