Summary: | [build.webkit.org] Update dashboard links for layout test results | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, ap, jbedard, lingho, ryanhaddad, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=221822 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 175056 | ||||||||
Attachments: |
|
Description
Aakash Jain
2021-02-02 12:15:06 PST
Created attachment 419136 [details]
Patch
Comment on attachment 419136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review > Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200 > + url = this.baseURLForResults; This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean Comment on attachment 419136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419136&action=review >> Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Buildbot.js:200 >> + url = this.baseURLForResults; > > This doesn't look right. `options && options.baseURLForResults` should resolve to a boolean Ok, I see what we're doing here, but I'm not sure this is the clearest way to express this. Can we change `this.baseURLForResults = options && options.baseURLForResults` to `this.baseURLForResults = options ? options.baseURLForResults : null` Created attachment 419325 [details]
Patch
commit-queue failed to commit attachment 419325 [details] to WebKit repository. To retry, please set cq+ flag again.
Committed r272399: <https://trac.webkit.org/changeset/272399> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419325 [details]. |