Bug 221262

Summary: [macOS] Add support for accessibility image extraction
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Adjust for changes in #221236
none
Patch for landing
wenson_hsieh: commit-queue+
Patch for landing none

Wenson Hsieh
Reported 2021-02-02 08:52:46 PST
<rdar://problem/70744978>
Attachments
Patch (3.54 KB, patch)
2021-02-03 08:43 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Adjust for changes in #221236 (3.92 KB, patch)
2021-02-05 13:35 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.91 KB, patch)
2021-02-06 21:16 PST, Wenson Hsieh 		wenson_hsieh: commit-queue+
DetailsFormatted DiffDiff
Patch for landing (3.90 KB, patch)
2021-02-06 21:24 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-02-03 08:43:15 PST
Created attachment 419141 [details] Patch
Devin Rousso
Comment 2 2021-02-03 13:21:09 PST
Comment on attachment 419141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419141&action=review rs=me > Source/WebKit/WebProcess/WebPage/WebPage.cpp:7154 > + element->updateWithImageExtractionResult(WTFMove(result)); Just making sure, but I'm guessing that this will be added by Bug 221236, right?
Wenson Hsieh
Comment 3 2021-02-03 13:22:05 PST
(In reply to Devin Rousso from comment #2) > Comment on attachment 419141 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419141&action=review > > rs=me > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:7154 > > + element->updateWithImageExtractionResult(WTFMove(result)); > > Just making sure, but I'm guessing that this will be added by Bug 221236, > right? Yep! (It's just green on EWS currently because the feature flag is disabled by default).
Wenson Hsieh
Comment 4 2021-02-05 13:35:35 PST
Created attachment 419455 [details] Adjust for changes in #221236
Wenson Hsieh
Comment 5 2021-02-06 21:16:55 PST
Created attachment 419527 [details] Patch for landing
Wenson Hsieh
Comment 6 2021-02-06 21:24:37 PST
Created attachment 419528 [details] Patch for landing
EWS
Comment 7 2021-02-06 22:08:13 PST
Committed r272470: <https://commits.webkit.org/r272470> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419528 [details].
Note You need to log in before you can comment on or make changes to this bug.