Bug 221221

Summary:

Remove the Timer from Style::Scope

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

CSS

Assignee:

Antti Koivisto <koivisto>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, esprehn+autocc, ews-watchlist, kangil.han, sam, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	sam: review+, ews-feeder: commit-queue-
patch	none
patch	ews-feeder: commit-queue-
patch	none
TestExpectation followup	none

Simon Fraser (smfr)

Reported 2021-02-01 11:44:47 PST

The timer in Style::Scope should be replaced with a rendering update or whatever Document::updateStyleIfNeeded() does.

Attachments
patch (3.43 KB, patch) 2021-02-02 08:31 PST, Antti Koivisto	sam: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (3.91 KB, patch) 2021-02-02 22:30 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
patch (4.00 KB, patch) 2021-02-02 22:36 PST, Antti Koivisto	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (5.54 KB, patch) 2021-02-04 03:09 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
TestExpectation followup (1.55 KB, patch) 2021-02-04 21:01 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2021-02-01 11:45:17 PST

This timer's construction time shows up in Speedometer profiles.

Antti Koivisto

Comment 2 2021-02-02 08:31:37 PST

Created attachment 419002 [details] patch

Simon Fraser (smfr)

Comment 3 2021-02-02 09:56:13 PST

Nice!

Antti Koivisto

Comment 4 2021-02-02 22:30:15 PST

Created attachment 419110 [details] patch

Antti Koivisto

Comment 5 2021-02-02 22:36:28 PST

Created attachment 419111 [details] patch

EWS

Comment 6 2021-02-02 23:35:07 PST

Committed r272300: <https://trac.webkit.org/changeset/272300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419111 [details].

Radar WebKit Bug Importer

Comment 7 2021-02-02 23:36:14 PST

<rdar://problem/73918532>

Ryan Haddad

Comment 8 2021-02-03 12:36:35 PST

Reverted r272300 for reason: Caused imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic-remove-style-detached.html to consistently fail on bots Committed r272336: <https://trac.webkit.org/changeset/272336>

Antti Koivisto

Comment 9 2021-02-04 03:09:52 PST

Created attachment 419263 [details] patch

EWS

Comment 10 2021-02-04 08:56:36 PST

Committed r272370: <https://trac.webkit.org/changeset/272370> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419263 [details].

Antti Koivisto

Comment 11 2021-02-04 21:01:06 PST

Created attachment 419360 [details] TestExpectation followup imported/w3c/web-platform-tests/css/css-scoping/css-scoping-shadow-dynamic-remove-style-detached.html shouldn't be flaky anymore

Antti Koivisto

Comment 12 2021-02-04 21:02:37 PST

add a followup

EWS

Comment 13 2021-02-04 23:34:19 PST

commit-queue failed to commit attachment 419360 [details] to WebKit repository. To retry, please set cq+ flag again.

EWS

Comment 14 2021-02-05 00:01:05 PST

commit-queue failed to commit attachment 419360 [details] to WebKit repository. To retry, please set cq+ flag again.

EWS

Comment 15 2021-02-05 04:38:47 PST

commit-queue failed to commit attachment 419360 [details] to WebKit repository. To retry, please set cq+ flag again.

EWS

Comment 16 2021-02-05 23:51:33 PST

Committed r272460: <https://trac.webkit.org/changeset/272460> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419360 [details].

Note You need to log in before you can comment on or make changes to this bug.