Bug 221206

Summary: [SOUP] Stop using SoupBuffer in preparation for libsoup3
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, berto, bugs-noreply, cdumez, ews-watchlist, gustavo, gyuyoung.kim, ryuan.choi, sergio, svillar
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220508    
Attachments:
Description Flags
Patch
none
Patch svillar: review+

Carlos Garcia Campos
Reported 2021-02-01 07:13:29 PST
It's gone in libsoup3, we can just use GBytes instead.
Attachments
Patch (35.36 KB, patch)
2021-02-01 07:16 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (35.36 KB, patch)
2021-02-01 07:56 PST, Carlos Garcia Campos 		svillar: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-02-01 07:16:48 PST
Created attachment 418870 [details] Patch
Carlos Garcia Campos
Comment 2 2021-02-01 07:56:22 PST
Created attachment 418874 [details] Patch
Sergio Villar Senin
Comment 3 2021-02-01 08:03:18 PST
Comment on attachment 418874 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418874&action=review > Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69 > + SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr), auto* soupBuffer ? Also I guess this would be migrated later right? Consider adding a comment.
Adrian Perez
Comment 4 2021-02-01 08:19:41 PST
Comment on attachment 418874 [details] Patch LGTM as well View in context: https://bugs.webkit.org/attachment.cgi?id=418874&action=review >> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69 >> + SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr), > > auto* soupBuffer ? > > Also I guess this would be migrated later right? Consider adding a comment. I assume that there will be later a patch adding the support to actually use libsoup3 inside “#if SOUP_CHECK_VERSION(2, 91, 0)” guards (or similar) and this version of the code will be in the “#else” arm of the conditional =]
Carlos Garcia Campos
Comment 5 2021-02-02 00:51:01 PST
(In reply to Adrian Perez from comment #4) > Comment on attachment 418874 [details] > Patch > > LGTM as well > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418874&action=review > > >> Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp:69 > >> + SoupBuffer* soupBuffer = soup_buffer_new_with_owner(g_bytes_get_data(data, nullptr), > > > > auto* soupBuffer ? > > > > Also I guess this would be migrated later right? Consider adding a comment. > > I assume that there will be later a patch adding the support to actually > use libsoup3 inside “#if SOUP_CHECK_VERSION(2, 91, 0)” guards (or similar) > and > this version of the code will be in the “#else” arm of the conditional =] Exactly, it will be kept in the libsoup2 branch
Carlos Garcia Campos
Comment 6 2021-02-02 00:52:51 PST
Committed r272196: <https://trac.webkit.org/changeset/272196>
Note You need to log in before you can comment on or make changes to this bug.