Summary: | [JSC] Add @ in Error.stack if URL exists | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John A. Bilicki III <jab_creations> | ||||||||
Component: | JavaScriptCore | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ashvayka, ews-watchlist, fpizlo, hi, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari 14 | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
John A. Bilicki III
2021-01-31 02:25:08 PST
While Error.stack format is not standardized (this means any format is OK), maybe, having @ for source URL case is not so bad idea. Created attachment 418830 [details]
Patch
Comment on attachment 418830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418830&action=review > Source/JavaScriptCore/ChangeLog:8 > + Append '@' if URL exists even if function name does not exist. Can you say why you want this here? Comment on attachment 418830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418830&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Append '@' if URL exists even if function name does not exist. > > Can you say why you want this here? Added :) Created attachment 418831 [details]
Patch
Created attachment 418843 [details]
Patch
Committed r272139: <https://trac.webkit.org/changeset/272139> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418843 [details]. |