Summary: | Make check for full HashTables opt-in | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tadeu Zagallo <tzagallo> | ||||||
Component: | Web Template Framework | Assignee: | Tadeu Zagallo <tzagallo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, saam, webkit-bug-importer, ysuzuki | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tadeu Zagallo
2021-01-29 16:18:12 PST
Created attachment 418786 [details]
Patch
Comment on attachment 418786 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418786&action=review > Source/WTF/ChangeLog:9 > + Having the check always on was a regression on Speedometer2. you should say what you did, e.g, opt in metaallocator Comment on attachment 418786 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418786&action=review r=me too with one comment. > Source/WTF/wtf/MetaAllocator.h:197 > + HashMap<FreeSpacePtr, FreeSpaceNode*, DefaultHash<FreeSpacePtr>, HashTraits<FreeSpacePtr>, HashTraits<FreeSpaceNode*>, true> m_freeSpaceStartAddressMap; > + HashMap<FreeSpacePtr, FreeSpaceNode*, DefaultHash<FreeSpacePtr>, HashTraits<FreeSpacePtr>, HashTraits<FreeSpaceNode*>, true> m_freeSpaceEndAddressMap; Some enum would be better for readability, like, enum class HashTableHardeningMode : uint8_t { None, AssertNotFull, }; And HashMap<FreeSpacePtr, FreeSpaceNode*, DefaultHash<FreeSpacePtr>, HashTraits<FreeSpacePtr>, HashTraits<FreeSpaceNode*>, HashTableHardeningMode:: AssertNotFull> Created attachment 418793 [details]
Patch for landing
Committed r272095: <https://trac.webkit.org/changeset/272095> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418793 [details]. |