Bug 221156

Summary: [macOS] Remove support for image controls
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, joepeck, kangil.han, kondapallykalyan, macpherson, menard, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
thorton: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch for landing none

Wenson Hsieh
Reported 2021-01-29 14:01:38 PST
Remove support for image controls
Attachments
For EWS (86.11 KB, patch)
2021-01-29 16:04 PST, Wenson Hsieh 		thorton: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (88.24 KB, patch)
2021-01-29 19:44 PST, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (85.05 KB, patch)
2021-01-30 08:31 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-01-29 16:04:31 PST
Created attachment 418780 [details] For EWS
Tim Horton
Comment 2 2021-01-29 16:19:20 PST
Comment on attachment 418780 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=418780&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:100 > -@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_AVAILABLE(macos(10.12)); > +@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_DEPRECATED("Image controls are no longer supported", macos(10.12, WK_MAC_TBA)); Don't we have pretty strong evidence that we can just delete this?
Wenson Hsieh
Comment 3 2021-01-29 16:50:27 PST
Comment on attachment 418780 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=418780&action=review >> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:100 >> +@property (nonatomic, setter=_setImageControlsEnabled:) BOOL _imageControlsEnabled WK_API_DEPRECATED("Image controls are no longer supported", macos(10.12, WK_MAC_TBA)); > > Don't we have pretty strong evidence that we can just delete this? Ah, so after some more digging, it looks like Mail actually turns on this SPI for some of their web views, but then never attempts to set the corresponding attribute (x-webkit-imagemenu) on any image elements. When using web inspector to manually add the attribute, I'm able to get a button to show up when hovering over images, but it doesn't have any effect. As such, it seems that use of this SPI by Mail was unintentional, so while we can't remove the SPI quite yet, marking it as deprecated is probably a good first step.
Wenson Hsieh
Comment 4 2021-01-29 19:44:41 PST
Created attachment 418803 [details] Patch
EWS
Comment 5 2021-01-29 21:27:38 PST
commit-queue failed to commit attachment 418803 [details] to WebKit repository.
Wenson Hsieh
Comment 6 2021-01-30 08:31:09 PST
Created attachment 418815 [details] Patch for landing
EWS
Comment 7 2021-01-30 10:47:49 PST
Committed r272117: <https://trac.webkit.org/changeset/272117> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418815 [details].
Radar WebKit Bug Importer
Comment 8 2021-01-30 10:48:13 PST
<rdar://problem/73794193>
Note You need to log in before you can comment on or make changes to this bug.