Bug 221039

Summary: [macOS] Re-enable ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2021-01-27 06:06:31 PST
In <https://trac.webkit.org/changeset/271907>, ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS was disabled due to a crash. The crash should be addressed and the define should be turned on again.
Attachments
Patch (4.75 KB, patch)
2021-01-27 06:30 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (5.31 KB, patch)
2021-01-27 09:31 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-01-27 06:30:23 PST
Created attachment 418539 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-01-27 09:24:01 PST
<rdar://problem/73665061>
Per Arne Vollan
Comment 3 2021-01-27 09:31:57 PST
Created attachment 418555 [details] Patch
Brent Fulgham
Comment 4 2021-01-27 09:44:40 PST
Comment on attachment 418555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review The relevant parts of this patch look good, but it seems like some unrelated work got included. Can you fix the patch? > Source/WebCore/platform/mac/ThemeMac.mm:72 > +} I don't think this is an intended part of your change. > Source/WebCore/platform/mac/ThemeMac.mm:82 > + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; I don't think this is an intended part of your change.
Brent Fulgham
Comment 5 2021-01-27 09:53:51 PST
Comment on attachment 418555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review r=me >> Source/WebCore/platform/mac/ThemeMac.mm:72 >> +} > > I don't think this is an intended part of your change. Oh! I see, this was intentional! >> Source/WebCore/platform/mac/ThemeMac.mm:82 >> + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; > > I don't think this is an intended part of your change. I'm wrong -- you explained in your Changelog. Sorry for not catching that.
Per Arne Vollan
Comment 6 2021-01-27 10:06:12 PST
(In reply to Brent Fulgham from comment #5) > Comment on attachment 418555 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418555&action=review > > r=me > > >> Source/WebCore/platform/mac/ThemeMac.mm:72 > >> +} > > > > I don't think this is an intended part of your change. > > Oh! I see, this was intentional! > > >> Source/WebCore/platform/mac/ThemeMac.mm:82 > >> + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; > > > > I don't think this is an intended part of your change. > > I'm wrong -- you explained in your Changelog. Sorry for not catching that. No worries, thanks for reviewing!
EWS
Comment 7 2021-01-27 10:37:00 PST
Committed r271965: <https://trac.webkit.org/changeset/271965> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418555 [details].
Note You need to log in before you can comment on or make changes to this bug.