Summary: | [macOS] Re-enable ENABLE_SET_WEBCONTENT_PROCESS_INFORMATION_IN_NETWORK_PROCESS | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-01-27 06:06:31 PST
Created attachment 418539 [details]
Patch
Created attachment 418555 [details]
Patch
Comment on attachment 418555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review The relevant parts of this patch look good, but it seems like some unrelated work got included. Can you fix the patch? > Source/WebCore/platform/mac/ThemeMac.mm:72 > +} I don't think this is an intended part of your change. > Source/WebCore/platform/mac/ThemeMac.mm:82 > + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; I don't think this is an intended part of your change. Comment on attachment 418555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418555&action=review r=me >> Source/WebCore/platform/mac/ThemeMac.mm:72 >> +} > > I don't think this is an intended part of your change. Oh! I see, this was intentional! >> Source/WebCore/platform/mac/ThemeMac.mm:82 >> + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; > > I don't think this is an intended part of your change. I'm wrong -- you explained in your Changelog. Sorry for not catching that. (In reply to Brent Fulgham from comment #5) > Comment on attachment 418555 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418555&action=review > > r=me > > >> Source/WebCore/platform/mac/ThemeMac.mm:72 > >> +} > > > > I don't think this is an intended part of your change. > > Oh! I see, this was intentional! > > >> Source/WebCore/platform/mac/ThemeMac.mm:82 > >> + styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:YES]; > > > > I don't think this is an intended part of your change. > > I'm wrong -- you explained in your Changelog. Sorry for not catching that. No worries, thanks for reviewing! Committed r271965: <https://trac.webkit.org/changeset/271965> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418555 [details]. |