Bug 221035

Summary: [MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sam, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220826
Bug Depends on:    
Bug Blocks: 220966    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2021-01-27 05:36:17 PST
[MacOS] Enable WebKitTestRunner audio and video capture in GPUProcess
Attachments
Patch (2.40 KB, patch)
2021-01-27 05:37 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.63 KB, patch)
2021-01-28 00:46 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (5.27 KB, patch)
2021-01-28 12:55 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-27 05:37:32 PST
Created attachment 418535 [details] Patch
youenn fablet
Comment 2 2021-01-28 00:46:29 PST
Created attachment 418628 [details] Patch
Eric Carlson
Comment 3 2021-01-28 10:50:15 PST
Comment on attachment 418628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418628&action=review > Tools/ChangeLog:9 > + On iOS, capture ill still happen inprocess for the time being. s/ill/still/
Sam Weinig
Comment 4 2021-01-28 12:01:56 PST
Comment on attachment 418628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418628&action=review > Tools/WebKitTestRunner/TestController.cpp:933 > +#if PLATFORM(MAC) > + WKPreferencesSetCaptureAudioInGPUProcessEnabled(preferences, true); > + WKPreferencesSetCaptureVideoInGPUProcessEnabled(preferences, true); > +#endif Please keep this in TestOptions.cpp. Trying to have all the state in one place moving away from having it here.
youenn fablet
Comment 5 2021-01-28 12:55:55 PST
Created attachment 418663 [details] Patch
EWS
Comment 6 2021-01-29 01:01:28 PST
Committed r272053: <https://trac.webkit.org/changeset/272053> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418663 [details].
Radar WebKit Bug Importer
Comment 7 2021-01-29 01:03:28 PST
<rdar://problem/73745204>
Note You need to log in before you can comment on or make changes to this bug.