Bug 22099

Summary: Make the Qt port build the JSC shell in the correct place
Product: WebKit Reporter: Peter Gal <galpeter>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch for fixing jsc.pro includes
none
fixed proposed patch zwarich: review+

Peter Gal
Reported 2008-11-06 05:10:07 PST
After moving the jsc.pro file in rev 38155 not all includes was modified to follow the changes. Part of it was fixed in rev 38163, but for example: the jsc binary ended up in the 'WebKitBuild/Release/' directory instead of the 'WebKitBuild/Release/JavaScriptCore/'. I think this will break JavaScriptCore tests, because jsc binary is not in the correct folder.
Attachments
proposed patch for fixing jsc.pro includes (1.46 KB, patch)
2008-11-06 05:10 PST, Peter Gal 		no flags
DetailsFormatted DiffDiff
fixed proposed patch (1.34 KB, patch)
2008-11-06 05:33 PST, Peter Gal 		zwarich: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 2008-11-06 05:10:50 PST
Created attachment 24940 [details] proposed patch for fixing jsc.pro includes
Peter Gal
Comment 2 2008-11-06 05:33:47 PST
Created attachment 24941 [details] fixed proposed patch Previous patch had a little typo. Sorry for that.
Cameron Zwarich (cpst)
Comment 3 2008-11-06 09:25:01 PST
Comment on attachment 24941 [details] fixed proposed patch This looks good to me, but doublecheck that it builds 'jsc' and runs tests correctly in a clean build. The bot is still running the tests fine, presumedly because it is using the old executable.
Peter Gal
Comment 4 2008-11-06 09:43:57 PST
After a clean build I started the tests and the sunspider, both was good.
Cameron Zwarich (cpst)
Comment 5 2008-11-06 10:34:07 PST
Okay, I'll land it.
Cameron Zwarich (cpst)
Comment 6 2008-11-06 10:43:46 PST
Landed in r38185.
Note You need to log in before you can comment on or make changes to this bug.