Bug 220987 – Web Inspector: add Box Model into Layout panel

• Component: Web Inspector
• Status: RESOLVED FIXED

[Nikita Vasilyev]

I'm going to add Box Model to the experimental Layout panel. Once Layout panel is enabled by default, the plan is to remove Box Model from the Computed panel.

<rdar://problem/73503841>

[Nikita Vasilyev]

Created attachment 418920 [details]
Patch

[Nikita Vasilyev]

Created attachment 418921 [details]
[Video] With patch applied

[Blaze Burg]

Comment on attachment 418920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418920&action=review

r=me with some little things

> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:43
> +            return hasDOMNode;

Nit: I prefer `return false`, it's easier to understand without any context.

> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:91
>          // FIXME: Move the Box Model section here from the Computed panel.

Nit: remove the FIXME

> Source/WebInspectorUI/UserInterface/Views/LayoutDetailsSidebarPanel.js:106
>      // Private

I believe this needs to be ported over as well:


    get minimumWidth()
    {
        return this._boxModelDiagramRow?.minimumWidth ?? 0;
    }

[Devin Rousso]

Comment on attachment 418920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418920&action=review

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: move Box Model into Layout panel

Seeing as how this patch doesn't touch the Computed panel, I'd rename the bug "add" instead of "move" (the latter implies that it's taken from it's old location, which is not the case as I mentioned).

[Nikita Vasilyev]

Created attachment 418935 [details]
Patch

[EWS]

Committed r272182: <https://trac.webkit.org/changeset/272182>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418935 [details].