Bug 220982

Summary: Set ruby-indent-level to 4
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fujii.hironori, mark.lam, webkit-bug-importer, xan.lopez, yoshiaki.jitsukawa, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2021-01-26 07:34:51 PST
Set ruby-indent-level to 4
Attachments
Patch (883 bytes, patch)
2021-01-26 07:36 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2021-01-26 08:15 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2021-01-26 07:36:30 PST
Created attachment 418417 [details] Patch
Angelos Oikonomopoulos
Comment 2 2021-01-26 08:15:56 PST
Created attachment 418422 [details] Patch
Fujii Hironori
Comment 3 2021-01-26 11:45:20 PST
What about other languages? Perl and Python? What about an idea adding the following? [*] indent_style = space indent_size = 4
Angelos Oikonomopoulos
Comment 4 2021-01-27 01:50:32 PST
(In reply to Fujii Hironori from comment #3) > What about other languages? Perl and Python? > What about an idea adding the following? > > [*] > indent_style = space > indent_size = 4 Adding a wildcard would make a coding style decision for future languages as well, something I'm not terribly comfortable with. I know the webkit code style guidelines dictate that "The indent size is 4 spaces" but they also have a python section that simply says "For Python use PEP8 style". So I can't assume an indent size of 4 is mandated for every language used in WebKit (as it might reasonably come in conflict with much more established norms in a language community). Also, I'm not aware of the coding style conventions for all the languages as they are currently used in WebKit. If someone who has touched a lot of perl/python files in WebKit feels that's appropriate, we could add them explicitly alongside C++, C and ruby?
EWS
Comment 5 2021-01-27 04:12:34 PST
Committed r271945: <https://trac.webkit.org/changeset/271945> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418422 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-27 04:13:16 PST
<rdar://problem/73657473>
Note You need to log in before you can comment on or make changes to this bug.