| Summary: | Set ruby-indent-level to 4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | Hironori.Fujii, mark.lam, webkit-bug-importer, xan.lopez, yoshiaki.jitsukawa, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Angelos Oikonomopoulos
2021-01-26 07:34:51 PST
Created attachment 418417 [details]
Patch
Created attachment 418422 [details]
Patch
What about other languages? Perl and Python? What about an idea adding the following? [*] indent_style = space indent_size = 4 (In reply to Fujii Hironori from comment #3) > What about other languages? Perl and Python? > What about an idea adding the following? > > [*] > indent_style = space > indent_size = 4 Adding a wildcard would make a coding style decision for future languages as well, something I'm not terribly comfortable with. I know the webkit code style guidelines dictate that "The indent size is 4 spaces" but they also have a python section that simply says "For Python use PEP8 style". So I can't assume an indent size of 4 is mandated for every language used in WebKit (as it might reasonably come in conflict with much more established norms in a language community). Also, I'm not aware of the coding style conventions for all the languages as they are currently used in WebKit. If someone who has touched a lot of perl/python files in WebKit feels that's appropriate, we could add them explicitly alongside C++, C and ruby? Committed r271945: <https://trac.webkit.org/changeset/271945> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418422 [details]. |