Bug 22097

Summary: Expose MessageEvent constructor on WorkerContext
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore JavaScriptAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2008-11-05 23:48:09 PST
Since MessageEvent is used in workers, we should expose its constructor.
Attachments
proposed patch (3.13 KB, patch)
2008-11-05 23:49 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-11-05 23:49:37 PST
Created attachment 24936 [details] proposed patch
Darin Adler
Comment 2 2008-11-06 09:29:01 PST
Comment on attachment 24936 [details] proposed patch > +void setJSWorkerContextMessageEvent(ExecState*, JSObject*, JSValue*) > +{ > + ASSERT_NOT_REACHED(); > +} Why this instead of ReadOnly? r=me
Alexey Proskuryakov
Comment 3 2008-11-06 09:41:07 PST
(In reply to comment #2) > > + ASSERT_NOT_REACHED(); > Why this instead of ReadOnly? I don't know - like other setters, I modeled this after what JSDOMWindowBase does - it doesn't make the constructors read-only, but overrides put() to have special behavior for those. I only have a FIXME for this in setJSWorkerContextMessageChannel now: // FIXME: Do we need to override put for global constructors, like JSDOMWindowBase does?
Alexey Proskuryakov
Comment 4 2008-11-06 21:55:06 PST
Committed revision 38212.
Note You need to log in before you can comment on or make changes to this bug.