| Summary: | Expose MessageEvent constructor on WorkerContext | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
| Component: | WebCore JavaScript | Assignee: | Alexey Proskuryakov <ap> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Alexey Proskuryakov
2008-11-05 23:48:09 PST
Created attachment 24936 [details]
proposed patch
Comment on attachment 24936 [details] proposed patch > +void setJSWorkerContextMessageEvent(ExecState*, JSObject*, JSValue*) > +{ > + ASSERT_NOT_REACHED(); > +} Why this instead of ReadOnly? r=me (In reply to comment #2) > > + ASSERT_NOT_REACHED(); > Why this instead of ReadOnly? I don't know - like other setters, I modeled this after what JSDOMWindowBase does - it doesn't make the constructors read-only, but overrides put() to have special behavior for those. I only have a FIXME for this in setJSWorkerContextMessageChannel now: // FIXME: Do we need to override put for global constructors, like JSDOMWindowBase does? Committed revision 38212. |