Bug 220966

Summary: Enable webrtc video capture in GPUProcess for iOS WebKitTestRunner
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 220936, 221035    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

youenn fablet
Reported 2021-01-26 01:17:44 PST
Enable webrtc capture in WebKitTestRunner (iOS)
Attachments
Patch (2.09 KB, patch)
2021-01-26 01:25 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.10 KB, patch)
2021-01-29 06:42 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.81 KB, patch)
2021-02-01 01:58 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (4.85 KB, patch)
2021-02-01 04:22 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-26 01:25:11 PST
Created attachment 418378 [details] Patch
Alexey Proskuryakov
Comment 2 2021-01-27 14:46:12 PST
Comment on attachment 418378 [details] Patch It is hard for me to understand why this does what the ChangeLog says. The patch removes disabling WebRTCPlatformCodecsInGPUProcessEnabled cross-platform, enables CaptureAudioInGPUProcessEnabled on Mac, and CaptureVideoInGPUProcessEnabled cross-platform. More explanation in ChangeLog could be useful.
youenn fablet
Comment 3 2021-01-28 00:26:07 PST
(In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 418378 [details] > Patch > > It is hard for me to understand why this does what the ChangeLog says. The > patch removes disabling WebRTCPlatformCodecsInGPUProcessEnabled > cross-platform, enables CaptureAudioInGPUProcessEnabled on Mac, and > CaptureVideoInGPUProcessEnabled cross-platform. More explanation in > ChangeLog could be useful. Bug title is not clear, this is about enabling webrtc capture in GPUProcess in WTR on iOS.
youenn fablet
Comment 4 2021-01-29 06:42:34 PST
Created attachment 418721 [details] Patch
youenn fablet
Comment 5 2021-01-29 12:33:25 PST
Following tests are failing: fast/speechrecognition/ios/audio-capture.html fast/speechrecognition/ios/restart-recognition-after-stop.html fast/speechrecognition/ios/start-recognition-then-stop.html platform/ios/mediastream/video-muted-in-background-tab.html First 3 are probably due to speech recognition not working in GPU process. 3rd one is using internals API which is not well supported with GPUProcess. But there is probably a need to better handle the case of visibility interruption on iOS when GPU process is doing the capture.
youenn fablet
Comment 6 2021-02-01 01:58:58 PST
Created attachment 418848 [details] Patch
youenn fablet
Comment 7 2021-02-01 04:22:16 PST
Created attachment 418856 [details] Patch
Radar WebKit Bug Importer
Comment 8 2021-02-02 01:18:21 PST
<rdar://problem/73869764>
EWS
Comment 9 2021-02-03 02:34:48 PST
Committed r272304: <https://trac.webkit.org/changeset/272304> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418856 [details].
Note You need to log in before you can comment on or make changes to this bug.