Bug 22096

Summary: REGRESSION (r35879): scrolldelay is counted in seconds instead of miliseconds
Product: WebKit Reporter: Roy B. Carter <rcarter>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: VERIFIED FIXED    
Severity: Normal CC: cmarrin, hyatt, webkit
Priority: P1 Keywords: HasReduction, Regression
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
URL: http://www.anamosa.k12.ia.us
Attachments:
Description Flags
minimal test case
none
fix for the issue darin: review+

Roy B. Carter
Reported 2008-11-05 20:24:00 PST
The scrolling banner headline for web page does not scroll using webkit r38068 or previous, does scroll using regular Safari v3.1.2 browser.
Attachments
minimal test case (93 bytes, text/html)
2008-12-27 12:02 PST, Robert Blaut 		no flags
Details
fix for the issue (4.28 KB, patch)
2009-01-07 04:53 PST, Robert Blaut 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Blaut
Comment 1 2008-12-27 12:02:11 PST
I can confirm this bug as reggresion bug. Scrolldelay sets the amount of delay in milliseconds (a millisecond is 1/1000th of a second). Actually WebKit uses seconds instead of miliseconds. Check attached test case. You can inspect the test case. Inspector shows: -webkit-marquee-speed: 10s; instead of -webkit-marquee-speed: 10ms;
Robert Blaut
Comment 2 2008-12-27 12:02:55 PST
Created attachment 26271 [details] minimal test case
Robert Blaut
Comment 3 2009-01-05 01:21:17 PST
This changeset <http://trac.webkit.org/changeset/35879> caused regression.
Robert Blaut
Comment 4 2009-01-07 04:53:57 PST
Created attachment 26490 [details] fix for the issue
Darin Adler
Comment 5 2009-01-07 07:38:39 PST
Comment on attachment 26490 [details] fix for the issue r=me
Brent Fulgham
Comment 6 2009-01-12 16:25:17 PST
Landed in r39848.
Roy B. Carter
Comment 7 2009-01-13 14:59:11 PST
It works on our home page! Thank you!
Note You need to log in before you can comment on or make changes to this bug.