Bug 220953

Summary: Changes to commit-log-editor should trigger webkitpy EWS tests
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: Tools / TestsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, darin, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220950
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryan Haddad
Reported 2021-01-25 15:20:26 PST
Since checkout_unittest.py includes tests that rely on commit-log-editor, we should ensure that changes to that commit-log-editor trigger webkitpy test runs in EWS.
Attachments
Patch (1.28 KB, patch)
2021-01-25 15:31 PST, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2021-01-25 15:34 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (2.87 KB, patch)
2021-01-25 15:41 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-25 15:23:54 PST
<rdar://problem/73590954>
Ryan Haddad
Comment 2 2021-01-25 15:31:13 PST
Created attachment 418348 [details] Patch
Aakash Jain
Comment 3 2021-01-25 15:34:26 PST
Created attachment 418352 [details] Patch
Darin Adler
Comment 4 2021-01-25 15:38:42 PST
Comment on attachment 418352 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418352&action=review > Tools/CISupport/ews-build/steps_unittest.py:2423 > + file_names = ['Tools/Scripts/webkitpy', 'Tools/Scripts/libraries', 'Tools/Script/commit-log-editor'] This won’t work because it says "Script" instead of "Scripts".
Aakash Jain
Comment 5 2021-01-25 15:41:34 PST
Created attachment 418353 [details] Patch
Aakash Jain
Comment 6 2021-01-25 15:42:01 PST
(In reply to Darin Adler from comment #4) > This won’t work because it says "Script" instead of "Scripts". Good catch. Fixed in updated patch.
EWS
Comment 7 2021-01-25 16:50:59 PST
Committed r271869: <https://trac.webkit.org/changeset/271869> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418353 [details].
Note You need to log in before you can comment on or make changes to this bug.