Bug 220952

Summary:

[macOS] Close all XPC connections to Launch Services after checking in

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

WebKit Misc.

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

221094

Bug Blocks:

Attachments:

Description	Flags
Patch	bfulgham: review+
Patch	none

Per Arne Vollan

Reported 2021-01-25 15:08:43 PST

After checking in with Launch Services on macOS, close all open XPC connections to the service.

Attachments
Patch (3.26 KB, patch) 2021-01-25 15:23 PST, Per Arne Vollan	bfulgham: review+	Details Formatted Diff Diff
Patch (3.49 KB, patch) 2021-01-26 10:05 PST, Per Arne Vollan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Per Arne Vollan

Comment 1 2021-01-25 15:09:48 PST

<rdar://13785139>

Per Arne Vollan

Comment 2 2021-01-25 15:23:11 PST

Created attachment 418344 [details] Patch

Brent Fulgham

Comment 3 2021-01-26 09:02:36 PST

Comment on attachment 418344 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418344&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:323 > + // FIXME: Replace the constant 4 with kLSServerConnectionStatusReleaseNotificationsMask when available in the SDK. Can you add a Bugzilla here so we don't forget? > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:459 > + if (!m_networkProcessConnection) This feels very unusual. Should we log when this happens? > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:746 > + if (!m_networkProcessConnection) Ditto. Updating activate page information when the network process is dead seems unusual. Might be worth logging in case it is relevant to user-visible bugs.

Per Arne Vollan

Comment 4 2021-01-26 10:05:24 PST

Created attachment 418435 [details] Patch

Per Arne Vollan

Comment 5 2021-01-26 10:06:59 PST

(In reply to Brent Fulgham from comment #3) > Comment on attachment 418344 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418344&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:323 > > + // FIXME: Replace the constant 4 with kLSServerConnectionStatusReleaseNotificationsMask when available in the SDK. > > Can you add a Bugzilla here so we don't forget? > Done. > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:459 > > + if (!m_networkProcessConnection) > > This feels very unusual. Should we log when this happens? > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:746 > > + if (!m_networkProcessConnection) > > Ditto. Updating activate page information when the network process is dead > seems unusual. Might be worth logging in case it is relevant to user-visible > bugs. Fixed in latest patch. Thanks for reviewing!

EWS

Comment 6 2021-01-26 13:03:48 PST

Committed r271897: <https://trac.webkit.org/changeset/271897> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418435 [details].

Chris Dumez

Comment 7 2021-01-28 10:44:55 PST

I don't think this change was correct. Following up in Bug 221094.

Note You need to log in before you can comment on or make changes to this bug.