Summary: | DumpRenderTree behaves differently to WebKitTestRunner wrt integrated/discrete GPU behavior | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
Component: | Tools / Tests | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Other | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 220843 | ||||||||||
Attachments: |
|
Description
Kimmo Kinnunen
2021-01-22 02:29:40 PST
Created attachment 418122 [details]
Patch
Comment on attachment 418122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418122&action=review I didn't know about this key, and this is an excellent thing to consider. Just to confirm, this changes nothing on the bots, correct? Presumably most Legacy WebKit clients don't have NSSupportsAutomaticGraphicsSwitching in their plists, so we should continue to test WebGL with discrete GPU on bots that have it. > Tools/ChangeLog:12 > + * DumpRenderTree/Info.plist: Added. This file should be in DumpRenderTree/mac. > Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:1416 > baseConfigurationReference = BCB281F00CFA713D007E533E /* DumpRenderTree.xcconfig */; > buildSettings = { > + CREATE_INFOPLIST_SECTION_IN_BINARY = YES; > + INFOPLIST_FILE = "$(SRCROOT)/Info.plist"; Even though iOS has this in .xcodeproj, adding configurations to xcodeproj makes me cringe. Normally, everything should be in .xcconfig. Created attachment 418263 [details]
Patch
Created attachment 418264 [details]
Patch
(In reply to Alexey Proskuryakov from comment #2) > I didn't know about this key, and this is an excellent thing to consider. > Just to confirm, this changes nothing on the bots, correct? Correct. As far as I understand, --prefer-integrated-gpu is not used on bots. The intended behavior change is only for --prefer-integrated-gpu > Even though iOS has this in .xcodeproj, adding configurations to xcodeproj > makes me cringe. Normally, everything should be in .xcconfig. Done, as far as I understand. Committed r271792: <https://trac.webkit.org/changeset/271792> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418264 [details]. |