Bug 220800

Summary: [webkitscmpy] Handle machines that cannot import keyring
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jonathan Bedard
Reported 2021-01-21 09:05:43 PST
Although keyring is certainly useful so a contributor does not have to constantly input their password, it's not needed for the library the function. We should effectively make it an optional import.
Attachments
Patch (3.95 KB, patch)
2021-01-21 09:21 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-21 09:05:59 PST
<rdar://problem/73454666>
Jonathan Bedard
Comment 2 2021-01-21 09:21:45 PST
Created attachment 418047 [details] Patch
EWS
Comment 3 2021-01-21 09:54:59 PST
Committed r271697: <https://trac.webkit.org/changeset/271697> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418047 [details].
Note You need to log in before you can comment on or make changes to this bug.