Bug 220797

Summary:

test bug

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ews-watchlist

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Aakash Jain

Reported 2021-01-21 07:34:58 PST Comment hidden (obsolete)

To break up the lab(), lch() change, it was opted to initially land with an explicit clamp to sRGB to avoid the subtle rounding issues we were seeing with CG. We should remove explicit clamp to SRGB by either: - Explicit conversion to ExtendedSRGB (-Inf,Inf), which will avoid using CG's color conversion code, but won't be re-usable down the road if we want to use CG for things like gradients in the Lab color space. - Passing the Lab color to CG and identifying and working around the precision issues in the tests. Note: this is a test bug, please ignore :)

Attachments
Patch (3.23 KB, patch) 2021-01-21 07:36 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Patch (3.23 KB, patch) 2021-01-21 09:22 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2021-01-21 07:36:30 PST

Created attachment 418040 [details] Patch

Aakash Jain

Comment 2 2021-01-21 09:22:12 PST

Created attachment 418048 [details] Patch

Note You need to log in before you can comment on or make changes to this bug.