Bug 220704

Summary: Extend getUserMedia quirk to warbyparker.com
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, hta, jer.noble, kondapallykalyan, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2021-01-18 00:50:46 PST
Extend getUserMedia quirk to warbyparker.com
Attachments
Patch (3.35 KB, patch)
2021-01-18 01:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.51 KB, patch)
2021-01-20 01:07 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-01-18 00:50:58 PST
<rdar://problem/72839707>
youenn fablet
Comment 2 2021-01-18 01:11:46 PST
Created attachment 417814 [details] Patch
youenn fablet
Comment 3 2021-01-20 01:07:58 PST
Created attachment 417952 [details] Patch
EWS
Comment 4 2021-01-20 12:51:33 PST
Committed r271667: <https://trac.webkit.org/changeset/271667> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417952 [details].
Darin Adler
Comment 5 2021-01-20 14:55:07 PST
Comment on attachment 417952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417952&action=review > Source/WebCore/page/Quirks.cpp:869 > + m_shouldEnableLegacyGetUserMediaQuirk = host == "www.baidu.com" || host == "www.warbyparker.com"; Why did we stop using equalLettersIgnoringASCIICase? I don’t think a case sensitive check is right for a host name.
youenn fablet
Comment 6 2021-01-20 23:30:10 PST
(In reply to Darin Adler from comment #5) > Comment on attachment 417952 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417952&action=review > > > Source/WebCore/page/Quirks.cpp:869 > > + m_shouldEnableLegacyGetUserMediaQuirk = host == "www.baidu.com" || host == "www.warbyparker.com"; > > Why did we stop using equalLettersIgnoringASCIICase? I don’t think a case > sensitive check is right for a host name. This is an optimization since we are using SecurityOrigin::host, which is lower cased. I guess we could revert back to caseless checks in Quirks.cpp for consistency. Or introduce matching methods with SecurityOrigin instead for clarity.
Darin Adler
Comment 7 2021-01-21 08:56:31 PST
Comment on attachment 417952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417952&action=review >>> Source/WebCore/page/Quirks.cpp:869 >>> + m_shouldEnableLegacyGetUserMediaQuirk = host == "www.baidu.com" || host == "www.warbyparker.com"; >> >> Why did we stop using equalLettersIgnoringASCIICase? I don’t think a case sensitive check is right for a host name. > > This is an optimization since we are using SecurityOrigin::host, which is lower cased. > I guess we could revert back to caseless checks in Quirks.cpp for consistency. > Or introduce matching methods with SecurityOrigin instead for clarity. Got it. I didn’t notice that this is calling a different host function now. Code seems fine. Thank you for answering my question.
Note You need to log in before you can comment on or make changes to this bug.