Summary: | [GTK] Multilib conflicts in gir files | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||||||
Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | annulen, bugs-noreply, cgarcia, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | PC | ||||||||||
OS: | Linux | ||||||||||
Attachments: |
|
Description
Michael Catanzaro
2021-01-14 14:51:10 PST
(In reply to Michael Catanzaro from comment #0) > Our generated gir files currently include absolute paths. Er, well that's not true. Point remains: paths need to be relative to the builddir or we'll have multilib conflicts. Created attachment 417660 [details]
Patch
Created attachment 417661 [details]
Patch
Comment on attachment 417661 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417661&action=review > Source/JavaScriptCore/PlatformGTK.cmake:83 > + --sources-top-dirs=${CMAKE_BINARY_DIR} > + --sources-top-dirs=${CMAKE_SOURCE_DIR} why do we need to pass both? do we want the toplevel soures dir or the toplevel build dir? (In reply to Carlos Garcia Campos from comment #4) > Comment on attachment 417661 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417661&action=review > > > Source/JavaScriptCore/PlatformGTK.cmake:83 > > + --sources-top-dirs=${CMAKE_BINARY_DIR} > > + --sources-top-dirs=${CMAKE_SOURCE_DIR} > > why do we need to pass both? do we want the toplevel soures dir or the > toplevel build dir? The first version of my patch only passed the builddir, which is sufficient to avoid the multilib conflicts. Then I looked into what meson was doing and realized it was passing both. Setting the builddir shortens the paths for anything built from DerivedSources, while setting sourcedir just shortens the paths for things under Source/ when the introspection scanner is called from a subdirectory of the toplevel source directory. Except... cmake actually runs all commands from the toplevel source directory, so passing it does nothing (except make the command line longer). So yeah, it's not needed. Let's go back to the first version of my patch. Er... also it seems I missed the WebKit2WebExtension-4.0.gir... oops. Will fix that in the patch that lands. Created attachment 417831 [details]
Patch for landing
Committed r271580: <https://trac.webkit.org/changeset/271580> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417831 [details]. |