Bug 220578

Summary: [WPE] focus-visible-003.html and focus-visible-004.html are timing out in input tags
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, cdumez, cgarcia, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, jfernandez, lmoura, mifenton, rego, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220312
Bug Depends on: 185859    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Lauro Moura 2021-01-12 22:41:19 PST 
imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html
imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html

Both are getting stuck when reaching the `<button ...>` tag test, with the focus event not being triggered and making the Promise to get stuck, not following into the assertions.

Running with WPE's MiniBrowser, all input controls except color (not yet supported in WPE) does not show either the Red or Green outlines with the results of the test.
Comment 1 Lauro Moura 2021-01-12 22:46:29 PST 
Updated expectations to Failure in r271431
Comment 2 Manuel Rego Casasnovas 2021-01-20 09:10:26 PST 
Created attachment 417974 [details]
Patch
Comment 3 Lauro Moura 2021-01-20 13:19:14 PST 
Comment on attachment 417974 [details]
Patch

Testing locally, the patch indeed fixes the tests and seems to introduce no new regressions.

Putting up r? flag.
Comment 4 Javier Fernandez 2021-01-20 13:30:25 PST 
Comment on attachment 417974 [details]
Patch

r=me
Comment 5 Lauro Moura 2021-01-20 13:31:18 PST 
Comment on attachment 417974 [details]
Patch

Thanks!
Comment 6 EWS 2021-01-20 13:41:56 PST 
Committed r271671: <https://trac.webkit.org/changeset/271671>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417974 [details].
Comment 7 Radar WebKit Bug Importer 2021-01-20 13:42:14 PST 
<rdar://problem/73418537>