Bug 220549

Summary: [macOS] GPU Process unable to play MSE content due to missing sandbox rules
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, jer.noble, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2021-01-12 10:40:30 PST 
A number of services allowed in the WebContent process are missing from the GPU Process on macOS, especially for Apple Silicon. This needs to be corrected.
Comment 1 Radar WebKit Bug Importer 2021-01-12 10:40:50 PST 
<rdar://problem/73047290>
Comment 2 Brent Fulgham 2021-01-12 10:55:40 PST 
Created attachment 417471 [details]
Patch
Comment 3 Per Arne Vollan 2021-01-12 11:14:20 PST 
Comment on attachment 417471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417471&action=review

R=me.

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:667
> +       (global-name "com.apple.audio.toolbox.reporting.service")

This is a diagnostics service, I believe, which does not seem to be required for features to be working correctly. Perhaps we can avoid adding this?
Comment 4 Brent Fulgham 2021-01-12 15:52:17 PST 
(In reply to Per Arne Vollan from comment #3)
> Comment on attachment 417471 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417471&action=review
> 
> R=me.
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:667
> > +       (global-name "com.apple.audio.toolbox.reporting.service")
> 
> This is a diagnostics service, I believe, which does not seem to be required
> for features to be working correctly. Perhaps we can avoid adding this?

Let's leave it for now. We hit this during the failed playback case so I'm worried it won't work right without it.
Comment 5 EWS 2021-01-12 16:06:40 PST 
Committed r271421: <https://trac.webkit.org/changeset/271421>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417471 [details].