Bug 220547

Summary: [webkitcorepy] Add TaskPool
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dean_johnson, dewei_zhu, jlewis3, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217680
https://bugs.webkit.org/show_bug.cgi?id=220791
https://bugs.webkit.org/show_bug.cgi?id=227715
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Jonathan Bedard
Reported 2021-01-12 09:25:16 PST
We need a multiprocessing architecture compatible with Python 3.8. Rather than attempt to retro-fit webkitpy's existing architecture, I think we should develop a new one to use going forward.
Attachments
Patch (21.54 KB, patch)
2021-01-12 09:27 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (21.64 KB, patch)
2021-01-12 09:35 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (21.67 KB, patch)
2021-01-19 07:53 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (22.14 KB, patch)
2021-01-20 11:27 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (22.12 KB, patch)
2021-01-20 18:11 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.09 KB, patch)
2021-10-01 11:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-12 09:26:10 PST
<rdar://problem/73043887>
Jonathan Bedard
Comment 2 2021-01-12 09:27:53 PST
Created attachment 417461 [details] Patch
Jonathan Bedard
Comment 3 2021-01-12 09:35:52 PST
Created attachment 417463 [details] Patch
Alexey Proskuryakov
Comment 4 2021-01-12 17:54:39 PST
*** Bug 220546 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Comment 5 2021-01-19 07:53:12 PST
Created attachment 417875 [details] Patch
Jonathan Bedard
Comment 6 2021-01-20 11:27:08 PST
Created attachment 417981 [details] Patch
Jonathan Bedard
Comment 7 2021-01-20 11:29:46 PST
(In reply to Jonathan Bedard from comment #6) > Created attachment 417981 [details] > Patch Sam and I talked today, they had some good points, namely: Making the queue a class variable of Process may encourage future code to mess with the state of the TaskPool and ensuring that we don't encounter deadlocks when queues get full.
dewei_zhu
Comment 8 2021-01-20 14:40:29 PST
r=me
Jonathan Bedard
Comment 9 2021-01-20 18:11:04 PST
Created attachment 418010 [details] Patch for landing
EWS
Comment 10 2021-01-20 18:51:30 PST
Committed r271683: <https://trac.webkit.org/changeset/271683> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418010 [details].
Aakash Jain
Comment 11 2021-01-21 04:13:50 PST
Noticing ImportError (while importing six) after this, see: https://bugs.webkit.org/show_bug.cgi?id=220791
Jonathan Bedard
Comment 12 2021-10-01 11:48:24 PDT
Reopening to attach new patch.
Jonathan Bedard
Comment 13 2021-10-01 11:48:25 PDT
Created attachment 439886 [details] Patch for landing
EWS
Comment 14 2021-10-01 12:46:11 PDT
Committed r283391 (242395@main): <https://commits.webkit.org/242395@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439886 [details].
Note You need to log in before you can comment on or make changes to this bug.