Bug 220460

Summary: GraphicsContextGLOpenGL::reshapeFBOs() ANGLE variant calls into makeContextCurrent()
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 218896    
Attachments:
Description Flags
Patch
none
Patch none

Description Kimmo Kinnunen 2021-01-08 05:22:07 PST 
GraphicsContextGLOpenGL::reshapeFBOs() ANGLE variant calls into makeContextCurrent() 

The calls to makeCurrentContext() should only be made during entering of a public method.
The call fails in certain conditions during reshape(), as reshape() is in middle of reshaping the default frame buffer and currently makeContextCurrent() uses the size information to determine if the context is in valid state or not.

Long term the " the size information to determine"-part should be removed, but it's a bit tricky to test.
Removing the redundant makeContextCurrent() calls should be a goal anyway, so fixing this leaf problem should be a good short term fix.
Comment 1 Kimmo Kinnunen 2021-01-08 05:25:55 PST 
Created attachment 417265 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-01-12 04:00:08 PST 
Created attachment 417443 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-01-15 05:23:13 PST 
<rdar://problem/73245417>
Comment 4 EWS 2021-01-17 23:41:47 PST 
Committed r271572: <https://trac.webkit.org/changeset/271572>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417443 [details].