Bug 220411

Summary: PaintFrameForMedia has a null identifier when media player is a media stream track video player
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Reuploading to run on bots none

youenn fablet
Reported 2021-01-07 06:35:40 PST
PaintFrameForMedia has a null identifier when media player is a media stream track video player
Attachments
Patch (5.90 KB, patch)
2021-01-07 06:55 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Reuploading to run on bots (8.84 KB, patch)
2021-01-08 02:51 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-07 06:52:58 PST
<rdar://problem/72888461>
youenn fablet
Comment 2 2021-01-07 06:55:06 PST
Created attachment 417176 [details] Patch
Wenson Hsieh
Comment 3 2021-01-07 10:03:54 PST
Comment on attachment 417176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review > Source/WebCore/platform/graphics/GraphicsContextImpl.h:108 > + virtual bool canPaintFrameForMedia(const MediaPlayer&) const = 0; I think you'll need to update this method for other platforms as well (i.e. Windows, Cairo, Nicosia).
Wenson Hsieh
Comment 4 2021-01-07 10:04:36 PST
Comment on attachment 417176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417176&action=review > Source/WebCore/ChangeLog:12 > + Covered by test in gu process mode. Nit - "gu" => "GPU"
youenn fablet
Comment 5 2021-01-08 02:51:53 PST
Created attachment 417259 [details] Reuploading to run on bots
EWS
Comment 6 2021-01-08 07:26:40 PST
Committed r271295: <https://trac.webkit.org/changeset/271295> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417259 [details].
Note You need to log in before you can comment on or make changes to this bug.