Bug (QtLauncherRobot) – QtLauncher robotization for testing purposes

• Component: Tools / Tests
• Status: RESOLVED DUPLICATE

[Balazs Kelemen]

I made a feature for QtLauncher: to load URL-s from a list file one by one.
The original goal was leak hunting, but I think it is usable for other testing
purposes or performance measuring as well.
I used the QtWebKit API. The loadFinished signal is the key of the
automatization. The feature can activated by the -r switch. The second parameter
should be the file with one URL at each line.
I hope you can find it useful.

[Balazs Kelemen]

Created attachment 24844 [details]
proposed patch

[Simon Hausmann]

Comment on attachment 24844 [details]
proposed patch

Is this patch obsolete through bug 20932 ?

[Balazs Kelemen]

I thought it would be better if I create a separeted bugreport for the
robotization feature. Where shall I send the new version that follows
your comments in bug 20932? Here or there?

[Balazs Kelemen]

*** This bug has been marked as a duplicate of 20932 ***

[Simon Hausmann]

Comment on attachment 24844 [details]
proposed patch

> Index: WebKit/qt/ChangeLog
> ===================================================================
> --- WebKit/qt/ChangeLog	(revision 37444)
> +++ WebKit/qt/ChangeLog	(working copy)
> @@ -1,3 +1,24 @@
> [phone]  System User  <set EMAIL_ADDRESS environment variable>

Please add your real name and email address.

> --- WebKit/qt/QtLauncher/QtLauncher.pro	(revision 37432)
> +++ WebKit/qt/QtLauncher/QtLauncher.pro	(working copy)
> @@ -3,6 +3,9 @@ SOURCES += main.cpp
>  CONFIG -= app_bundle
>  CONFIG += uitools
>  DESTDIR = ../../../bin
> +INCPATH += $$PWD/../../../JavaScriptCore/wtf
> +LIBS += -L../../../JavaScriptCore/ 
> +LIBS += -lJavaScriptCore

I don't think we should use the WTF types outside of WebCore, so this should not be necessary.

> +public slots:
> +    void loadNext()
> +    {
> +        QString qstr;
> +        if (getUrl(qstr)) {
> +            QUrl url(qstr, QUrl::StrictMode);
> +            if (url.isValid()) {
> +                m_stdOut<<"Loading "<<qstr<<" ......"<<endl;

Coding style, please put spaces between the arguments.

> +private:
> +    WTF::Vector<QString> m_urls;

I suggest the use of QStringList instead. This way we do not have to have to pull in WTF or the static JavaScriptCore library.

The rest of the patch looks good, heads up :)

[Balazs Kelemen]

I finished the patch in bug 20932. Now it uses QVector for the strings.
I'm sorry if I confused yo. I would not create this bugriport.
So, I leave this as a duplicate, and let's continue the discuss at bug 20932!