Summary: | unexpected minimumInputSize in setupDisjunctionOffsets for regexp engine(yarr) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | raycp <raycp> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, ews-feeder, keith_miller, msaboff, product-security, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
raycp
2021-01-06 04:48:11 PST
hello?? Created attachment 421660 [details]
Patch
Committed r273594: <https://commits.webkit.org/r273594> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421660 [details]. Comment on attachment 421660 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421660&action=review > JSTests/stress/regexp-max-size.js:36 > +function testMaxBMPRegExp() { > + let patt = '\u{1234}{4294967294}X'; > + const re = RegExp(patt, 'u'); > + return "\u{1234}\u{1234}X".match(re); > +} > + > +function testTooBigBMPRegExp() { > + let patt = '\u{1234}{4294967294}\u{4567}'; > + const re = RegExp(patt, 'u'); > + return "\u{1234}\u{1234}\u{4567}".match(re); > +} > + > +function testMaxNonBMPRegExp() { > + let patt = '\u{10234}{2147483646}\u{10100}'; > + const re = RegExp(patt, 'u'); > + return "\u{10234}\u{10234}\u{10100}".match(re); > +} > + > +function testTooBigNonBMPRegExp() { > + let patt = '\u{10234}{2147483646}\u{10100}'; > + const re = RegExp(patt, 'u'); > + return "\u{10234}\u{10234}\u{10100}".match(re); > +} > + None of these are called. (In reply to Keith Miller from comment #6) > Comment on attachment 421660 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421660&action=review > > > JSTests/stress/regexp-max-size.js:36 > > +function testMaxBMPRegExp() { > > + let patt = '\u{1234}{4294967294}X'; > > + const re = RegExp(patt, 'u'); > > + return "\u{1234}\u{1234}X".match(re); > > +} > > + > > +function testTooBigBMPRegExp() { > > + let patt = '\u{1234}{4294967294}\u{4567}'; > > + const re = RegExp(patt, 'u'); > > + return "\u{1234}\u{1234}\u{4567}".match(re); > > +} > > + > > +function testMaxNonBMPRegExp() { > > + let patt = '\u{10234}{2147483646}\u{10100}'; > > + const re = RegExp(patt, 'u'); > > + return "\u{10234}\u{10234}\u{10100}".match(re); > > +} > > + > > +function testTooBigNonBMPRegExp() { > > + let patt = '\u{10234}{2147483646}\u{10100}'; > > + const re = RegExp(patt, 'u'); > > + return "\u{10234}\u{10234}\u{10100}".match(re); > > +} > > + > > None of these are called. You're right. iCopy/paste error. Fixing now and will post an updated patch. |